-
-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update TCJA references to reconciliation version #1765
Conversation
The reconciliation TCJA: 1) Raises _DependentCredit_Nonchild_c to $500, not $300 (https://github.com/open-source-economics/Tax-Calculator/blob/master/taxcalc/reforms/TCJA_Reconciliation.json#L131) 2) Does away with _FilerCredit_c
@codykallen, Can you review PR #1765? |
Codecov Report
@@ Coverage Diff @@
## master #1765 +/- ##
======================================
Coverage 100% 100%
======================================
Files 37 37
Lines 3000 3027 +27
======================================
+ Hits 3000 3027 +27
Continue to review full report at Codecov.
|
Sure, it might make more sense to note either all TCJA changes or none, but
thought I'd make the minimal change for the previously noted ones.
…On Sat, Dec 16, 2017 at 10:42 AM Martin Holmer ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In taxcalc/current_law_policy.json
<#1765 (comment)>
:
> @@ -3679,7 +3679,6 @@
"section_1": "Nonrefundable Credits",
"section_2": "Child Tax Credit",
"irs_ref": "",
- "notes": "The Tax Cuts and Jobs Act sets this at $600 for joint and $300 for others",
Thanks @MaxGhenis <https://github.com/maxghenis>. I've been pretty much
out of the loop on the details of specifying the iterations of the TCJA
reforms, so I think it is best to wait for Cody's review. Thanks for your
careful review of our work.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1765 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFy2z7qLnmYkuAGGuwjm4CPGa2vxhwcEks5tBA8pgaJpZM4REZlD>
.
|
The primary value of having these TCJA references in |
@MattHJensen said:
@MaxGhenis, These are important points. How about dropping the dollar amounts and rewording the remaining "notes" fields to be something like |
Done, for the two that currently reference TCJA. I also filed #1777 as a longer-term feature request to understand the origin and evolution of each parameter. |
Thanks @MaxGhenis for the enhancement in pull request #1765. |
The reconciliation TCJA: